feat(bg_remover): harden skill to v0.2.0 - #268
Conversation
|
Thanks for the clean branch, much better than #266, I will close 266 and track here. This is closer on the runtime core (session cache, basic validation, 25 MB limit, mkdir for Still missing / fix
Bump is fine as |
e4cad04 to
61a942a
Compare
|
Thanks @AyushSrivastava1818, re-reviewed the latest commits on. The runtime core is in good shape now and mostly matches the earlier review / #257: session reuse, Base64 validation + shared 25 MB check, PIL That said, this is very close but still a bit behind ideal state and not completely ready to close #257 yet. Please ammend these in this PR so we don’t need a follow-up: Musts
Polish hints (same PR if easy)
Ping when those three must-fix items land and I’ll re-review for merge and close #257. <3 Good job so far and for following the steering accurately. |
|
Hey @AyushSrivastava1818, re-reviewed the latest fixes and most things are cleaned correctly. Well done <3 One tiny blocker before merge / close #257In
Optional but nice to have in this PR to avoid follow up PR:
After these are in, I’m happy to merge and close #257. Good work iterating on this. <3 |
Signed-off-by: AyushSrivastava1818 <ayush.sri0705@gmail.com>
1e78bf9 to
4f084df
Compare
Remove accidental commit-message line from examples/README.md and load manifest metadata from manifest.yaml to avoid version drift.
|
@AyushSrivastava1818, thanks for iterating on this, the runtime hardening looks good and matches the scope nicely. To save you another round-trip, I pushed a small maintainer commit onto your branch:
Bundle + registry docs tests still pass on my side. Good to merge from here, I'll merge and close #257 once CI is green. Nice work on this one. <3 |
|
@rosspeili can we connect on slack too? |
|
@AyushSrivastava1818 I don't use Slack outside orgs I am in, but you we can connect on any social or via email if you have any questions outside Skillware / ARPA repos. |
|
@rosspeili Okayy Bhai...will stay in touch loved contributing to skillware..great experience here... |
Description
Hardens the
creative/bg_removerskill to v0.2.0 by improving robustness, validation, and documentation.Fixes #257
Changes
output_path.Type of Change
skills/Checklist (all PRs)
Fixes #257)python -m black --check .andflake8pass locally (or CI-equivalent subset)pytest skills/andpytest tests/pass locally when relevantCHANGELOG.mdupdated under[Unreleased]when user-visible behavior changesexamples/README.mdupdated if this PR adds, renames, or removes a runnable scriptpytest tests/test_registry_docs.pywhen skills, examples index, or agent-loops matrix changedNew or updated skill
skills/<category>/<skill_name>/(fromtemplates/python_skill/or equivalent)manifest.yaml:name,version,description,parameters,constitution, realissuerskill.py(no ad-hoc LLM-generated execution paths)instructions.mdexplains when and how to use the skillcard.jsonissuer matches manifest when presenttest_skill.pycovers execution and schema expectationsdocs/skills/README.mdand row indocs/skills/README.mdConstitution and safety
This update improves input validation and filesystem safety by validating Base64 input and image files, rejecting missing, directory, empty, oversized (>25 MB), and invalid images, reusing cached rembg sessions, and automatically creating parent directories for
output_path.Related Issues
Fixes #257